Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meson.build: fix start-of-line_comment_prefix variable name #149

Merged
merged 1 commit into from
Dec 2, 2022
Merged

meson.build: fix start-of-line_comment_prefix variable name #149

merged 1 commit into from
Dec 2, 2022

Conversation

ihilt
Copy link
Contributor

@ihilt ihilt commented Dec 2, 2022

start-of-line_comment_prefix is not a valid identifier in Meson. It looks like this was partially addressed with sol_comment_prefix but didn't make it into actual usage.

benhoyt
benhoyt approved these changes Dec 2, 2022
View reviewed changes
Copy link
Owner

@benhoyt benhoyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me, thanks!

@benhoyt benhoyt merged commit d6e9d1b into benhoyt:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benhoyt benhoyt benhoyt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ihilt @benhoyt